feat: add references to room.info endpoint #33011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 4731573 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33011 +/- ##
========================================
Coverage 59.32% 59.32%
========================================
Files 2547 2547
Lines 63346 63346
Branches 14254 14254
========================================
Hits 37581 37581
Misses 23062 23062
Partials 2703 2703
Flags with carried forward coverage won't be shown. Click here to find out more. |
sampaiodiego
force-pushed
the
improve-rooms-info-endpoint
branch
from
cb74618
to
96c442f
Compare
MarcosSpessatto
requested changes
Sep 2, 2024
|
@MarcosSpessatto @KevLehman If you remove front-end related changes, please add through another PR. Julia can clarify why they're important. |
|
Yep, changes will be part of a separate PR. |
MarcosSpessatto
requested changes
Sep 2, 2024
KevLehman
reviewed
Sep 2, 2024
dionisio-bot
bot
added
stat: ready to merge
MarcosSpessatto
requested changes
Sep 4, 2024
MarcosSpessatto
approved these changes
Sep 5, 2024
dionisio-bot
bot
removed
the
stat: ready to merge
Merged
abhinavkrin
pushed a commit
that referenced
this pull request
Oct 25, 2024
Co-authored-by: Júlia Jaeger Foresti <[email protected]> Co-authored-by: Kevin Aleman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
rooms.infoendpoint will now include:parent: Represents the parent of a room. For discussions this is the room where the discussion was created, identified byprid. For rooms inside a team, the parent will be the team's main room, identified byteam.roomId. For other rooms, this property is undefined.team: Represents the team a room is part of. For rooms inside a team, this is the team identified byteamIdproperty. For everything else, this is undefined.Issue(s)
https://rocketchat.atlassian.net/browse/SIDE-155
Steps to test or reproduce
Further comments